fix summary, desc, and add test

pixee · Oct 4, 2023 · 6ac3925 · 6ac3925
1 parent 71cc68a
commit 6ac3925
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/src/core_codemods/lxml_safe_parser_defaults.py b/src/core_codemods/lxml_safe_parser_defaults.py
@@ -5,9 +5,9 @@
 
 class LxmlSafeParserDefaults(SemgrepCodemod):
     NAME = "safe-lxml-parser-defaults"
-    REVIEW_GUIDANCE = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW
-    SUMMARY = "Enable all security checks in `lxml.etree.XMLParser` call."
-    DESCRIPTION = "...........TODO"
+    REVIEW_GUIDANCE = ReviewGuidance.MERGE_WITHOUT_REVIEW
+    SUMMARY = "Use safe defaults for lxml parsers"
+    DESCRIPTION = "Replace lxml parser parameters with safe defaults"
 
     @classmethod
     def rule(cls):

diff --git a/tests/codemods/test_lxml_safe_parameter_defaults.py b/tests/codemods/test_lxml_safe_parameter_defaults.py
@@ -7,7 +7,7 @@
 )
 
 
-class TestJwtDecodeVerify(BaseSemgrepCodemodTest):
+class TestLxmlSafeParserDefaults(BaseSemgrepCodemodTest):
     codemod = LxmlSafeParserDefaults
 
     def test_name(self):
@@ -39,6 +39,21 @@ def test_from_import(self, tmpdir, klass):
 
 parser = {klass}(resolve_entities=False)
 var = "hello"
+"""
+
+        self.run_and_assert(tmpdir, input_code, expexted_output)
+
+    @each_class
+    def test_from_import_module(self, tmpdir, klass):
+        input_code = f"""from lxml import etree
+
+parser = etree.{klass}()
+var = "hello"
+"""
+        expexted_output = f"""from lxml import etree
+
+parser = etree.{klass}(resolve_entities=False)
+var = "hello"
 """
 
         self.run_and_assert(tmpdir, input_code, expexted_output)