update threading docs info

pixee · Oct 18, 2023 · 37cdfeb · 37cdfeb
1 parent 94a0b12
commit 37cdfeb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/core_codemods/with_threading_lock.py b/src/core_codemods/with_threading_lock.py
@@ -10,7 +10,7 @@ class WithThreadingLock(SemgrepCodemod, NameResolutionMixin):
     DESCRIPTION = (
         "Replace deprecated usage of threading lock classes as context managers."
     )
-    REVIEW_GUIDANCE = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW
+    REVIEW_GUIDANCE = ReviewGuidance.MERGE_WITHOUT_REVIEW
     REFERENCES = [
         {
             "url": "https://pylint.pycqa.org/en/latest/user_guide/messages/warning/useless-with-lock.",

diff --git a/src/scripts/generate_docs.py b/src/scripts/generate_docs.py
@@ -115,7 +115,8 @@ class DocMetadata:
         guidance_explained="We believe that using the walrus operator is an improvement in terms of clarity and readability. However, this change is only compatible with codebases that support Python 3.8 and later, so it requires quick validation before merging.",
     ),
     "bad-lock-with-statement": DocMetadata(
-        importance="Low", guidance_explained="TODO AFTER PR MERGE"
+        importance="Low",
+        guidance_explained="We believe this replacement is safe and should not result in any issues.",
     ),
 }