Fixes issue #4174 - Fix issues related to HttpHeaderManager.getDateHe…

…ader (#4175)
piranhacloud · Nov 8, 2024 · f12aeb9 · f12aeb9
1 parent 8a444a9
commit f12aeb9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/impl/src/main/java/cloud/piranha/core/impl/DefaultHttpHeaderManager.java b/core/impl/src/main/java/cloud/piranha/core/impl/DefaultHttpHeaderManager.java
@@ -84,7 +84,7 @@ public long getDateHeader(String name) throws IllegalArgumentException {
             DefaultHttpHeader header = headers.get(name.toUpperCase(locale));
             try {
                 String value = header.getValue();
-                SimpleDateFormat format = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
+                SimpleDateFormat format = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz", locale);
                 result = format.parse(value).getTime();
             } catch (ParseException exception) {
                 throw new IllegalArgumentException(

diff --git a/core/impl/src/test/java/cloud/piranha/core/impl/DefaultHttpHeaderManagerTest.java b/core/impl/src/test/java/cloud/piranha/core/impl/DefaultHttpHeaderManagerTest.java
@@ -30,6 +30,8 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.Enumeration;
+import java.util.Locale;
+
 import static org.junit.jupiter.api.Assertions.*;
 import org.junit.jupiter.api.Test;
 
@@ -82,7 +84,7 @@ void testContainsHeader() {
     @Test
     void testGetDateHeader() {
         DefaultHttpHeaderManager manager = new DefaultHttpHeaderManager();
-        SimpleDateFormat format = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
+        SimpleDateFormat format = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz", Locale.US);
         manager.addHeader("NAME", format.format(new Date()));
         assertTrue(manager.getDateHeader("NAME") > 0);
     }