Skip to content

Commit

Permalink
workaround for the inflexible cmake-arguments of android
Browse files Browse the repository at this point in the history
  • Loading branch information
pionere committed Dec 5, 2023
1 parent 1b10561 commit c200ed9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -482,16 +482,16 @@ jobs:
#name: [diablo, hellfire]
include:
- name: diablo
cmakeargs: ''
artifact: 'diablo-nightly-android.apk'
- name: hellfire
cmakeargs: '-DHELLFIRE=ON'
cmakearg0: '-DHELLFIRE=ON'
artifact: 'hellfire-nightly-android.apk'
- name: diablo-adrp
cmakeargs: '-D USE_PATCH=ON'
cmakearg0: '-DUSE_PATCH=ON'
artifact: 'diablo-nightly-androidp.apk'
- name: hellfire-adrp
cmakeargs: '-D USE_PATCH=ON -DHELLFIRE=ON'
cmakearg0: '-DUSE_PATCH=ON'
cmakearg1: '-DHELLFIRE=ON'
artifact: 'hellfire-nightly-androidp.apk'
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -525,7 +525,7 @@ jobs:
- name: Build
working-directory: ${{github.workspace}}
shell: bash
run: cd android-project && ./gradlew assembleRelease -Pcmakeargs="${{ matrix.cmakeargs }}"
run: cd android-project && ./gradlew assembleRelease -Pcmakearg0="${{ matrix.cmakearg0 }}" -Pcmakearg1="${{ matrix.cmakearg1 }}" -Pcmakearg2="${{ matrix.cmakearg2 }}"

- name: Upload-Package
uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion android-project/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ android {
versionName "1.0.0"
externalNativeBuild {
cmake {
arguments "-DANDROID_STL=c++_static", project.findProperty("cmakeargs")
arguments "-DANDROID_STL=c++_static", project.findProperty("cmakearg0"), project.findProperty("cmakearg1"), project.findProperty("cmakearg2")
abiFilters 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64'
}
}
Expand Down

0 comments on commit c200ed9

Please sign in to comment.