Use net.ErrClosed instead of io.EOF

Updates to use net.ErrClosed when connection has been closed. Signed-off-by: Daniel Mangum <[email protected]>
pion · Jul 11, 2023 · 9511282 · 9511282
1 parent d7008fb
commit 9511282
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/netctx/conn.go b/netctx/conn.go
@@ -68,7 +68,7 @@ func (c *conn) ReadContext(ctx context.Context, b []byte) (int, error) {
 
 	select {
 	case <-c.closed:
-		return 0, io.EOF
+		return 0, net.ErrClosed
 	default:
 	}
 

diff --git a/netctx/conn_test.go b/netctx/conn_test.go
@@ -97,8 +97,8 @@ func TestReadClosed(t *testing.T) {
 
 	b := make([]byte, 100)
 	n, err := c.ReadContext(context.Background(), b)
-	if !errors.Is(err, io.EOF) {
-		t.Errorf("Expected error '%v', got '%v'", io.EOF, err)
+	if !errors.Is(err, net.ErrClosed) {
+		t.Errorf("Expected error '%v', got '%v'", net.ErrClosed, err)
 	}
 	if n != 0 {
 		t.Errorf("Wrong data length, expected %d, got %d", 0, n)

diff --git a/netctx/packetconn.go b/netctx/packetconn.go
@@ -54,7 +54,7 @@ func (p *packetConn) ReadFromContext(ctx context.Context, b []byte) (int, net.Ad
 
 	select {
 	case <-p.closed:
-		return 0, nil, io.EOF
+		return 0, nil, net.ErrClosed
 	default:
 	}
 

diff --git a/netctx/packetconn_test.go b/netctx/packetconn_test.go
@@ -141,8 +141,8 @@ func TestReadFromClosed(t *testing.T) {
 
 	b := make([]byte, 100)
 	n, _, err := c.ReadFromContext(context.Background(), b)
-	if !errors.Is(err, io.EOF) {
-		t.Errorf("Expected error '%v', got '%v'", io.EOF, err)
+	if !errors.Is(err, net.ErrClosed) {
+		t.Errorf("Expected error '%v', got '%v'", net.ErrClosed, err)
 	}
 	if n != 0 {
 		t.Errorf("Wrong data length, expected %d, got %d", 0, n)