Perform handshake on first read/write

[kevmo314]

Description

Updates the connection to perform a handshake on first read/write instead of on accept.

Reference issue

#279

[Sean-Der]

PR looks beautiful to me! Matches Upstream and fixes biggest issue with lib at the moment :)

[codecov]

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.08%. Comparing base (bc3159a) to head (3e504d0).

Files	Patch %	Lines
conn.go	90.38%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   80.19%   80.08%   -0.11%     
==========================================
  Files         101      101              
  Lines        5336     5313      -23     
==========================================
- Hits         4279     4255      -24     
- Misses        687      689       +2     
+ Partials      370      369       -1     

Flag	Coverage Δ
go	80.11% <90.56%> (-0.11%)	⬇️
wasm	63.88% <84.90%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sean-Der]

Is it easy/possible to do 30 second timeout still with new APIs?

[kevmo314]

Yes, you would essentially call conn.HandshakeContext(<30 second timeout context>) manually before the first read/write. In other words, the sequence of calls would be something like:

for {
  conn := lis.Accept()
  go func() {
    if err := conn.Handshake(<30 second timeout context>); err != nil {
      ...
    }
    // regular read/write stuff
  }()
}

[Sean-Der]

Damn @kevmo314 really exceptional PR, I am so grateful for your help.

If you are in support I say we delete/break as much as we can now. Since we are doing a major release try to go with zero baggage.

Also would be nice to have zero functionally change in examples. Users can reference them when updating their code.

[kevmo314]

Also would be nice to have zero functionally change in examples. Users can reference them when updating their code.

Sounds good, I'll update them to include the timeout context.