Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit size of encrypted packet queue #628

Merged
merged 2 commits into from
May 2, 2024
Merged

limit size of encrypted packet queue #628

merged 2 commits into from
May 2, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Apr 17, 2024

No description provided.

@sukunrt sukunrt force-pushed the limit-enc-packets branch from 63e5fa9 to 7e1f7a8 Compare April 17, 2024 16:01
@sukunrt sukunrt requested a review from MarcoPolo April 17, 2024 16:03
@Sean-Der
Copy link
Member

Mind opening this one against master also

@sukunrt sukunrt mentioned this pull request Apr 25, 2024
22 tasks
Copy link

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just a small ask first.

conn.go Outdated
Comment on lines 163 to 171
mtu := config.MTU
if mtu <= 0 {
mtu = defaultMTU
}

replayProtectionWindow := config.ReplayProtectionWindow
if replayProtectionWindow <= 0 {
replayProtectionWindow = defaultReplayProtectionWindow
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these used in this func? Or is this a remnant of a copy/paste?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. These were a remnant of copy/paste.

@MarcoPolo
Copy link

Lets not forget to do the same change on master as well

@MarcoPolo MarcoPolo merged commit 24571ec into v2 May 2, 2024
5 of 10 checks passed
@MarcoPolo MarcoPolo deleted the limit-enc-packets branch May 2, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants