Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod to 1.19 #622

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update go.mod to 1.19 #622

merged 1 commit into from
Apr 3, 2024

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Apr 2, 2024

No description provided.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (ae51db9) to head (b401e48).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   77.96%   77.91%   -0.05%     
==========================================
  Files         101      101              
  Lines        6444     6444              
==========================================
- Hits         5024     5021       -3     
- Misses       1047     1050       +3     
  Partials      373      373              
Flag Coverage Δ
go 77.94% <ø> (-0.05%) ⬇️
wasm 62.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels requested a review from Sean-Der April 2, 2024 18:16
@edaniels
Copy link
Member Author

edaniels commented Apr 2, 2024

Looks fine but there's a flake that's not new

@daenney
Copy link
Member

daenney commented Apr 2, 2024

I don't think we can do this. Other things like pion/webrtc import this module, and they're still on 1.13. The dtls library would have to be one of the last ones to bump the Go version dependency.

@daenney
Copy link
Member

daenney commented Apr 2, 2024

That said I am in favour of starting to bump the minimum version across Pion. Nobody should be depending on Go 1.13 now. Would be nice to get to at least 1.18 so we can start making some use of generics.

Given 1.22 is current, I wouldn't mind bumping to 1.20 baseline overall either, as that also brings errors.Join in to the party which can be handy and a bunch more types satisfying Comparable which is nice when using generics.

@edaniels
Copy link
Member Author

edaniels commented Apr 3, 2024

Hey @daenney, we're upgrading to 1.19 across the board per pion/webrtc#2292

@Sean-Der Sean-Der merged commit 3e667b0 into master Apr 3, 2024
13 of 14 checks passed
@Sean-Der Sean-Der deleted the gomod19 branch April 3, 2024 02:36
@Sean-Der
Copy link
Member

Sean-Der commented Apr 3, 2024

Thanks for pushing back/asking questions @daenney :) lucky to have you around!

A few weeks ago we had a get together on Slack. The consensus was 1.19 was a good first step. I don't want to alienate users who get Go via pkg manager (Debian mostly)

I really would like to use more modern features/tooling though!

@daenney
Copy link
Member

daenney commented Apr 3, 2024

Ah, perfect! Nice to see the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants