-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.mod to 1.19 #622
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 77.96% 77.91% -0.05%
==========================================
Files 101 101
Lines 6444 6444
==========================================
- Hits 5024 5021 -3
- Misses 1047 1050 +3
Partials 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks fine but there's a flake that's not new |
I don't think we can do this. Other things like pion/webrtc import this module, and they're still on 1.13. The dtls library would have to be one of the last ones to bump the Go version dependency. |
That said I am in favour of starting to bump the minimum version across Pion. Nobody should be depending on Go 1.13 now. Would be nice to get to at least 1.18 so we can start making some use of generics. Given 1.22 is current, I wouldn't mind bumping to 1.20 baseline overall either, as that also brings |
Hey @daenney, we're upgrading to 1.19 across the board per pion/webrtc#2292 |
Relates to pion/webrtc#2292
Thanks for pushing back/asking questions @daenney :) lucky to have you around! A few weeks ago we had a get together on Slack. The consensus was 1.19 was a good first step. I don't want to alienate users who get Go via pkg manager (Debian mostly) I really would like to use more modern features/tooling though! |
Ah, perfect! Nice to see the upgrade. |
No description provided.