Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop invalid record silently during handshake #604

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

cnderrauber
Copy link
Member

Fix issue: invalid record in handshake staging cause readloop exited then handshake failed.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e8a7d7) 77.66% compared to head (585c2c5) 77.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   77.66%   77.76%   +0.09%     
==========================================
  Files         101      101              
  Lines        6435     6439       +4     
==========================================
+ Hits         4998     5007       +9     
+ Misses       1059     1056       -3     
+ Partials      378      376       -2     
Flag Coverage Δ
go 77.78% <100.00%> (+0.09%) ⬆️
wasm 63.13% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnderrauber cnderrauber force-pushed the hs_failed_invalidrecord branch from d093e44 to 7d1b408 Compare January 2, 2024 03:34
Fix issue: invalid record in handshake staging cause readloop
exited then handshake failed.
@cnderrauber cnderrauber force-pushed the hs_failed_invalidrecord branch from 7d1b408 to 585c2c5 Compare January 2, 2024 03:37
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job chasing this one @cnderrauber !!!

@cnderrauber cnderrauber merged commit 9ffd96c into master Jan 2, 2024
17 checks passed
@cnderrauber cnderrauber deleted the hs_failed_invalidrecord branch January 2, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants