Fix flight1parse processing exception #600
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 77.76% 77.91% +0.15%
==========================================
Files 101 101
Lines 6439 6444 +5
==========================================
+ Hits 5007 5021 +14
+ Misses 1056 1050 -6
+ Partials 376 373 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This looks good to me, although I would like another pair of eyes on it as a sanity check before merging. @cnderrauber / @davidzhao / @Sean-Der ? |
handshake_cache.go
Outdated
| out[t] = rawHandshake.Message | ||
| } | ||
| return seq, out, true | ||
| return seq, out, ok |
There was a problem hiding this comment.
should out be nil in case it's not found through the loop?
|
@minlp - can you take a look at @davidzhao's comment and push a change to your fork if needed? Then I think we can get this merged. |
I have already updated the code on the fix_dtls_flight1parse_except branch.@adriancable |
|
@minlp - ok great. Please squash the commit (you can retain the original title, “Fix flight1parse processing exception) and then assuming all checks are passed I will merge. Thank you! |
Description
Fix flight1parse processing exception
Reference issue
Fixes #...
pion/webrtc#2629