Add proxy support to Jenkins client #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up some unused methods
Add the following new properties to the `JenkinsFactory` configuration: * `useProxy` * `httpProxyAddr` * `httpProxyPort` These properties will be used in the `HttpClient` in the `Jenkins` class in order to support Jenkins calls through a proxy. Testing done: * Add unit tests which verify the proxy is used and `Host` header is sent * Will deploy to nonprod environment
knguyen100000010
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the following new properties to the
JenkinsFactoryconfiguration:useProxyhttpProxyAddrhttpProxyPortThese properties will be used in the
HttpClientin theJenkinsclassin order to support Jenkins calls through a proxy.
Testing Done
Hostheader issent