Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix false positive admin check table in bank2 again #403

Merged
merged 3 commits into from
Apr 19, 2021
Merged

fix false positive admin check table in bank2 again #403

merged 3 commits into from
Apr 19, 2021

Conversation

Thearas
Copy link
Contributor

@Thearas Thearas commented Apr 16, 2021

What problem does this PR solve?

#383 (comment).

What is changed and how does it work?

Ignore Error 1105: redirect failed when admin check table.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@Thearas Thearas requested review from cosven and zyguan April 16, 2021 11:00
zyguan
zyguan approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyguan
zyguan reviewed Apr 16, 2021
View reviewed changes
testcase/bank2/client.go Outdated Show resolved Hide resolved
@Thearas
Copy link
Contributor Author

Thearas commented Apr 19, 2021

PTAL again @zyguan .

@Thearas Thearas requested a review from zyguan April 19, 2021 03:08
@Thearas Thearas merged commit e772728 into pingcap:master Apr 19, 2021
@Thearas Thearas deleted the bank2 branch April 19, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosven cosven cosven approved these changes

@zyguan zyguan Awaiting requested review from zyguan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thearas @cosven @zyguan