-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the wrong schema.Clone implementation #57632
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57632 +/- ##
================================================
+ Coverage 72.8292% 73.4010% +0.5717%
================================================
Files 1676 1676
Lines 463753 463816 +63
================================================
+ Hits 337748 340446 +2698
+ Misses 105139 102613 -2526
+ Partials 20866 20757 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -79,7 +79,14 @@ func (s *Schema) Clone() *Schema { | |||
keys = append(keys, key.Clone()) | |||
} | |||
schema := NewSchema(cols...) | |||
schema.SetUniqueKeys(keys) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be we can add an ut to test Schema.Clone
itself?
What problem does this PR solve?
Issue Number: clone #57635
Problem Summary: planner: fix the wrong schema.Clone implementation
What changed and how does it work?
planner: fix the wrong schema.Clone implementation
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.