Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate CRD files (#5954) #5955

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5954

What problem does this PR solve?

Regenerate manifest files

What is changed and how does it work?

Run command make generate crd api-references

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (c23a794) to head (9c4eaa1).
Report is 8 commits behind head on release-1.6.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #5955      +/-   ##
===============================================
- Coverage        57.20%   57.03%   -0.17%     
===============================================
  Files              259      259              
  Lines            33233    44792   +11559     
===============================================
+ Hits             19010    25549    +6539     
- Misses           12290    17281    +4991     
- Partials          1933     1962      +29     
Flag Coverage Δ
unittest 57.03% <ø> (-0.17%) ⬇️
---- 🚨 Try these New Features:

@csuzhangxc csuzhangxc merged commit abe8ddd into pingcap:release-1.6 Nov 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants