Remove static functions that are provably never called. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce warning count to zero. All removed functions (BLSP_Boot2_Check_XZ_FW, BLSP_Boot2_Do_FW_Copy, BLSP_Boot2_Deal_One_FW, BLSP_Boot2_Rollback_PtEntry, BLSP_Boot2_Get_MFG_StartReq exist in the non-mini version at bl602_boot2/bl602_boot2/blsp_boot2.c. There is no reason to have this code here (and static, so it's provably never used) when all the callers have been removed. + Other misc hygeine to get default warning count to zero.
gamelaster
force-pushed
the
master
branch
2 times, most recently
from
5acb2ea
to
3c827b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce warning count to zero.
All removed functions (BLSP_Boot2_Check_XZ_FW, BLSP_Boot2_Do_FW_Copy, BLSP_Boot2_Deal_One_FW, BLSP_Boot2_Rollback_PtEntry,
BLSP_Boot2_Get_MFG_StartReq exist in the non-mini version at bl602_boot2/bl602_boot2/blsp_boot2.c. There is no reason to have this code here (and static, so it's provably never used) when all the callers have been removed.