Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the speakers model pluggable #160

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

chrisjrn
Copy link

This fork makes it so that you do not need to fork Symposion in order to update the speaker model.

It does the following:

  • Removes custom attributes from Speaker, and moves them to DefaultSpeaker
  • Adds configuration to let you set your preferred Speaker Form and Speaker Model
  • Makes the default speaker form a bit more useful
  • Adds documentation for plugging the speaker model

@jtauber
Copy link
Member

jtauber commented Aug 10, 2017

Thanks! I'm traveling at the moment (which is why I haven't been in the channel) but I'll take a look at this next week.

@chrisjrn
Copy link
Author

chrisjrn commented Aug 10, 2017 via email

@chrisjrn
Copy link
Author

So this branch appears to break migrations in some cases due to an ordering issue.

Before this can be merged, I'll need to patch the migrations to include some run_before clauses, and also add some documentation to that effect for consumer apps.

chrisjrn added a commit to chrisjrn/symposion that referenced this pull request Aug 13, 2017
chrisjrn added a commit to chrisjrn/symposion that referenced this pull request Aug 13, 2017
chrisjrn added a commit to chrisjrn/symposion that referenced this pull request Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants