-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the speakers model pluggable #160
Open
chrisjrn
wants to merge
11
commits into
pinax:master
Choose a base branch
from
chrisjrn:pluggable_speakers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing apps to create their own Speaker models.
Thanks! I'm traveling at the moment (which is why I haven't been in the channel) but I'll take a look at this next week. |
Thanks!
…On 11 August 2017 at 07:21, James Tauber ***@***.***> wrote:
Thanks! I'm traveling at the moment (which is why I haven't been in the
channel) but I'll take a look at this next week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#160 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAl-3O3UH15zrFfZjslo2TAqG_ofDtq3ks5sW3RogaJpZM4Oz_ZP>
.
--
--Christopher Neugebauer
Jabber: [email protected] -- IRC: chrisjrn on irc.freenode.net -- WWW:
http://chrisjrn.com -- Twitter: @chrisjrn
|
So this branch appears to break migrations in some cases due to an ordering issue. Before this can be merged, I'll need to patch the migrations to include some |
chrisjrn
added a commit
to chrisjrn/symposion
that referenced
this pull request
Aug 13, 2017
chrisjrn
added a commit
to chrisjrn/symposion
that referenced
this pull request
Aug 13, 2017
chrisjrn
added a commit
to chrisjrn/symposion
that referenced
this pull request
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork makes it so that you do not need to fork Symposion in order to update the speaker model.
It does the following:
Speaker
, and moves them toDefaultSpeaker