Run TypeScript tests in ts-node #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously ran the `test/type-test.ts` test through the TypeScript compiler to catch type issues, but there are more subtle problems that can happen at runtime with tools like `ts-node` (and maybe things like Deno, too -- I haven't tested that). This additionally *runs* the test file to make sure it doesn't throw at runtime, which would have caught issues like pimterry#196 ahead of time.
Test that the new test in ts-node is actually working. This needs to be reverted before shipping.
|
Ah, beautiful failure! This prints out some pretty good info in the GitHub Actions logs: 
|
|
✅ Should be safe to ship now! |
|
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously ran the
test/type-test.tstest through the TypeScript compiler to catch type issues, but there are more subtle problems that can happen at runtime with tools likets-node(and maybe things like Deno, too — I haven't tested that). This actually runs the test file in ts-node to make sure it doesn't throw at runtime, which would have caught issues like #196 ahead of time.