Skip to content

Commit

Permalink
[Improvement] Added class to tabBar (#38)
Browse files Browse the repository at this point in the history
* added class to `tabBar`

* Update composer.json

Pumped admin-ui-classic-bundle version to 1.1

* implemented helper function for tabbar

* Update public/js/document/printcontainer.js

* Update public/js/document/printpage.js

---------

Co-authored-by: robertSt7 <[email protected]>
  • Loading branch information
Corepex and robertSt7 authored Aug 24, 2023
1 parent 4f46683 commit bd2e352
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 23 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"minimum-stability": "dev",
"require": {
"pimcore/pimcore": "^11.0",
"pimcore/admin-ui-classic-bundle": "^1.0"
"pimcore/admin-ui-classic-bundle": "^1.1"
},
"require-dev": {
"phpstan/phpstan": "^1.10.5",
Expand Down
12 changes: 1 addition & 11 deletions public/js/document/printcontainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,8 @@ pimcore.document.printcontainer = Class.create(pimcore.document.printabstract, {
items.push(this.workflows.getLayout());
}

this.tabbar = new Ext.TabPanel({
tabPosition: "top",
region:'center',
deferredRender:true,
enableTabScroll:true,
defaults: {autoScroll:true},
border: false,
items: items,
activeTab: 0
});
this.tabbar = pimcore.helpers.getTabBar({items: items, defaults: {autoScroll:true}});
return this.tabbar;
}

});

12 changes: 1 addition & 11 deletions public/js/document/printpage.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,9 @@ pimcore.document.printpage = Class.create(pimcore.document.printabstract, {
items.push(this.workflows.getLayout());
}

this.tabbar = new Ext.TabPanel({
tabPosition: "top",
region:'center',
deferredRender:true,
enableTabScroll:true,
defaults: {autoScroll:true},
border: false,
items: items,
activeTab: 0
});
this.tabbar = pimcore.helpers.getTabBar({items: items, defaults: {autoScroll:true}});
return this.tabbar;
}

});


0 comments on commit bd2e352

Please sign in to comment.