Skip to content

Commit

Permalink
fix chromium to close page instead of closing browser
Browse files Browse the repository at this point in the history
Co-authored-by: Vincent Robert <[email protected]>
  • Loading branch information
kingjia90 and vrobert78 authored Feb 12, 2024
1 parent 4151b8a commit 6702070
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Processor/Chromium.php
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function getPdfFromString(string $html, array $params = [], bool $returnF
Logger::debug('Could not create pdf with chromium: '. print_r($e, true));
$output = (string) $e;
} finally {
$browser->close();
$page->close();

Check failure on line 139 in src/Processor/Chromium.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1, mariadb:10.11, lowest, false)

Variable $page might not be defined.

Check failure on line 139 in src/Processor/Chromium.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.2, mariadb:10.11, highest, 11.x-dev as 11.0.0, true)

Variable $page might not be defined.
}

return $output;
Expand Down

0 comments on commit 6702070

Please sign in to comment.