Fix SonarCloud pipeline in 1.x branch

assets/js/src/core/app/plugin-system/plugin-system.ts

@@ -15,17 +15,17 @@ import { container } from '@Pimcore/app/depency-injection'
 import { type Container } from 'inversify'
 import { moduleSystem } from '../module-system/module-system'
 
-export interface lifeCycleEvents {
+export interface ILifeCycleEvents {
   onInit?: (config: { container: Container }) => void
   onStartup?: (config: { moduleSystem: typeof moduleSystem }) => void
 }
 
-export interface abstractPlugin extends lifeCycleEvents {
+export interface IAbstractPlugin extends ILifeCycleEvents {
   name: string
 }
 
 export class PluginSystem {
-  private registry: Record<string, abstractPlugin> = {}
+  private registry: Record<string, IAbstractPlugin> = {}
 
   async loadPlugins (): Promise<void> {
     const promises: any[] = []
@@ -48,7 +48,7 @@ export class PluginSystem {
     await Promise.allSettled(promises)
   }
 
-  registerPlugin (plugin: abstractPlugin): void {
+  registerPlugin (plugin: IAbstractPlugin): void {
     this.registry[plugin.name] = plugin
   }
 

assets/js/src/core/app/store/index.ts

@@ -29,7 +29,11 @@ const slices: AnySliceLike[] = [
   pimcoreApi
 ]
 
-export let rootReducer = combineSlices({}, ...slices).withLazyLoadedSlices<LazyloadedSlices>()
+const createRootReducer = (): CombinedSliceReducer<Record<string, any>, Record<string, any>> => {
+  return combineSlices({}, ...slices).withLazyLoadedSlices<LazyloadedSlices>()
+}
+
+export const rootReducer = createRootReducer()
 
 export const store = configureStore({
   reducer: rootReducer,
@@ -47,10 +51,10 @@ export const store = configureStore({
 export const injectSliceWithState = (newSlice: AnySliceLike): CombinedSliceReducer<Record<string, any>, Record<string, any>> => {
   slices.push(newSlice)
 
-  rootReducer = combineSlices({}, ...slices).withLazyLoadedSlices<LazyloadedSlices>()
-  store.replaceReducer(rootReducer)
+  const updatedRootReducer = createRootReducer()
+  store.replaceReducer(updatedRootReducer)
 
-  return rootReducer
+  return updatedRootReducer
 }
 
 export type AppStore = typeof store

assets/js/src/core/components/alert/alert.stories.tsx

@@ -34,14 +34,14 @@ export const Success = {
   }
 }
 
-export const Error = {
+export const WithError = {
   args: {
     ..._default.args,
     type: 'error'
   }
 }
 
-export const Warning = {
+export const WithWarning = {
   args: {
     ..._default.args,
     type: 'warning'

assets/js/src/core/components/breadcrumb/breadcrumb.tsx

@@ -54,30 +54,30 @@ export const Breadcrumb = ({ path, elementType, editorTabsWidth, pageSize }: Bre
 
   let items: NonNullable<AntBreadcrumbProps['items']> = []
 
+  // Handle click event for intermediate parts of breadcrumb
+  const handleMenuItemClick = (path: string): void => {
+    const elementIdFetcher = dispatch(elementApi.endpoints.elementGetIdByPath.initiate({
+      elementType,
+      elementPath: path
+    }))
+
+    elementIdFetcher
+      .then(({ data }) => {
+        if (data !== undefined) {
+          openElement({
+            id: data.id,
+            type: elementType
+          }).catch(() => {})
+        }
+      })
+      .catch(() => {})
+  }
+
   function getBreadcrumbItems (path: string): AntBreadcrumbProps['items'] {
     // Split to check if it has more that just a single key
     const partList = path.split('/')
     const partListAmount = partList.length
 
-    // Handle click event for intermediate parts
-    const onMenuItemClick = (path: string): void => {
-      const elementIdFetcher = dispatch(elementApi.endpoints.elementGetIdByPath.initiate({
-        elementType,
-        elementPath: path
-      }))
-
-      elementIdFetcher
-        .then(({ data }) => {
-          if (data !== undefined) {
-            openElement({
-              id: data.id,
-              type: elementType
-            }).catch(() => {})
-          }
-        })
-        .catch(() => {})
-    }
-
     // Generate the breadcrumb text with ellipsis
     const generateBreadcrumbText = ({ content, style, className, hasFilename = false }: { content: string, style?: CSSProperties, className?: string, hasFilename?: boolean }): ReactElement => {
       if (hasFilename) {
@@ -116,7 +116,7 @@ export const Breadcrumb = ({ path, elementType, editorTabsWidth, pageSize }: Bre
         title: generateBreadcrumbText({ content: partList[partListAmount - 2], style: { maxWidth: '100px' } }),
         className: styles.pathItem,
         onClick: () => {
-          onMenuItemClick(partList.slice(0, partListAmount - 1).join('/'))
+          handleMenuItemClick(partList.slice(0, partListAmount - 1).join('/'))
         }
       })
 
@@ -128,7 +128,7 @@ export const Breadcrumb = ({ path, elementType, editorTabsWidth, pageSize }: Bre
               partList[i]
             ),
             onClick: () => {
-              onMenuItemClick(partList.slice(0, i + 1).join('/'))
+              handleMenuItemClick(partList.slice(0, i + 1).join('/'))
             }
           })
         }
@@ -146,7 +146,7 @@ export const Breadcrumb = ({ path, elementType, editorTabsWidth, pageSize }: Bre
             partList[i]
           ),
           onClick: () => {
-            onMenuItemClick(partList.slice(0, i + 1).join('/'))
+            handleMenuItemClick(partList.slice(0, i + 1).join('/'))
           }
         })
       }

assets/js/src/core/components/breadcrumb/hooks/use-breadcrumb-size.ts

@@ -23,60 +23,28 @@ export const useBreadcrumbSize = (editorTabsWidth?: number, initialBreadcrumbLas
   useLayoutEffect(() => {
     if (editorTabsWidth == null || initialBreadcrumbLastElementWidth == null) return
 
-    if (editorTabsWidth <= 375) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(50)
-    }
-
-    if (editorTabsWidth > 375 && editorTabsWidth <= 450) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(70)
-    }
-
-    if (editorTabsWidth > 450 && editorTabsWidth <= 550) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(85)
-    }
-
-    if (editorTabsWidth > 550 && editorTabsWidth <= 700) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(100)
-    }
-
-    if (editorTabsWidth > 700 && editorTabsWidth <= 800) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(150)
-    }
-
-    if (editorTabsWidth > 800 && editorTabsWidth <= 900) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(200)
-    }
-
-    if (editorTabsWidth > 900 && editorTabsWidth <= 1000) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(300)
-    }
-
-    if (editorTabsWidth > 1000 && editorTabsWidth <= 1100) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(400)
-    }
-
-    if (editorTabsWidth > 1100 && editorTabsWidth <= 1200) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(500)
-    }
-
-    if (editorTabsWidth > 1200 && editorTabsWidth <= 1300) {
-      setIsHideBreadcrumb(true)
-      setCurrentBreadcrumbWidth(600)
-    }
-
-    if (editorTabsWidth > 1300) {
-      setIsHideBreadcrumb(false)
-      setCurrentBreadcrumbWidth(initialBreadcrumbLastElementWidth)
-    }
+    const getBreadcrumbSettings = (width: number): { isHide: boolean, width: number } => {
+      if (width <= 375) return { isHide: true, width: 50 }
+      if (width <= 450) return { isHide: true, width: 70 }
+      if (width <= 550) return { isHide: true, width: 85 }
+      if (width <= 700) return { isHide: true, width: 100 }
+      if (width <= 800) return { isHide: true, width: 150 }
+      if (width <= 900) return { isHide: true, width: 200 }
+      if (width <= 1000) return { isHide: true, width: 300 }
+      if (width <= 1100) return { isHide: true, width: 400 }
+      if (width <= 1200) return { isHide: true, width: 500 }
+      if (width <= 1300) return { isHide: true, width: 600 }
+
+      return {
+        isHide: false,
+        width: initialBreadcrumbLastElementWidth
+      }
+    }
+
+    const { isHide, width } = getBreadcrumbSettings(editorTabsWidth)
+
+    setIsHideBreadcrumb(isHide)
+    setCurrentBreadcrumbWidth(width)
   }, [editorTabsWidth, initialBreadcrumbLastElementWidth])
 
   return { isHideBreadcrumb, currentBreadcrumbWidth }