Fixed download bug in details tab #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #601
Additional info
This pull request includes several changes to the
assets/js/src/core/app/api/pimcore/route.tsfile and related files to streamline URL handling and update localization, as well as updates to various build configuration files.API and URL Handling:
assets/js/src/core/app/api/pimcore/route.ts: Removed thegetDomainandgetDomainWithPrefixfunctions, leaving only thegetPrefixfunction. This simplifies URL handling by using a relative prefix instead of a hardcoded domain.assets/js/src/core/modules/asset/editor/types/image/tab-manager/tabs/preview/sidebar/tabs/details/details-container.tsx: Updated imports and fetch calls to usegetPrefixinstead ofgetDomainWithPrefix, ensuring URLs are constructed using the relative prefix. [1] [2] [3]Localization:
assets/js/src/core/modules/asset/editor/types/image/tab-manager/tabs/preview/sidebar/tabs/details/details-view.tsx: Updated the custom download option title to use a localized string.Build Configuration:
public/build/20c3a352-4f49-448e-ab48-5af98013c34e/entrypoints.json: Added new entry points for the main bundle.public/build/20c3a352-4f49-448e-ab48-5af98013c34e/manifest.json: Added the main bundle to the manifest.public/build/23b8db53-d155-4b0c-813f-2f538f0dc6e9/entrypoints.json: Added new entry points for the vendor bundle.public/build/23b8db53-d155-4b0c-813f-2f538f0dc6e9/manifest.json: Added the vendor bundle to the manifest.