Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #543

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Update README.md #543

merged 4 commits into from
Sep 23, 2024

Conversation

ValeriaMaltseva
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Sep 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ValeriaMaltseva
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

README.md Outdated
Comment on lines 5 to 7
#### Backend Admin Panel: `{your-domain}/admin`

#### Frontend UI: `{your-domain}/pimcore-studio`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the current admin domain here anymore.

This should be enough. :)
Admin UI: {your-domain}/pimcore-studio

Also this step is not needed anymore:

  • Login via the classic backend UI

Could you remove it? :) Christian already implemented the authentication for studio. So there is no need to use the current admin for login anymore.

Copy link

Copy link
Collaborator

@vin0401 vin0401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :)

@ValeriaMaltseva ValeriaMaltseva merged commit 77a4690 into 1.x Sep 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@ValeriaMaltseva ValeriaMaltseva deleted the readme-update branch September 23, 2024 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants