Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Toolbar #43

Merged
merged 36 commits into from
Feb 23, 2024
Merged

Add Toolbar #43

merged 36 commits into from
Feb 23, 2024

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Feb 19, 2024

Changes in this pull request

Resolves AP-81
Is Blocked By: #48

Additional info

@Corepex Corepex marked this pull request as ready for review February 19, 2024 09:05
@Corepex Corepex marked this pull request as draft February 19, 2024 09:07
@Corepex
Copy link
Contributor Author

Corepex commented Feb 20, 2024

change list:

  • currentColor for SVG
  • svg naming same as figma
  • change name toolbar to editorTabs
  • remove store
  • build factory for tab registry
  • add missing CSS styles

Copy link

github-actions bot commented Feb 21, 2024

Qodana for PHP

15 new problems were found

Inspection name Severity Problems
Line is longer than allowed by code style 🔶 Warning 15

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@Corepex Corepex marked this pull request as ready for review February 22, 2024 09:31
@vin0401 vin0401 merged commit 1be49f0 into 1.x Feb 23, 2024
@vin0401 vin0401 deleted the toolbar branch February 23, 2024 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants