[Feature] Added embedded metadata tab
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue with one of the endpoints. I will double-check that with @lukmzig. |
fixed with pimcore/studio-backend-bundle#82 |
|
@Corepex Not sure why but I have a problem with the authentication for the API when I try it with this branch together with the latest 1.x of the backend:
Is there something which we can check or should we wait until the session auth is done (should be done relatively soon on backend side)? |
vin0401
reviewed
Jun 12, 2024
...sset/editor/shared-tab-manager/tabs/embedded-metadata/embedded-metadata-container.styles.tsx
Outdated
Show resolved
Hide resolved
vs.
@Corepex From my point of view we can merge this PR as soon as we solved the first two points 👍 |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #151
Blocked by #237