Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][WIP] Settings #64

Merged
merged 5 commits into from
May 23, 2024
Merged

[Feature][WIP] Settings #64

merged 5 commits into from
May 23, 2024

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented May 16, 2024 •
edited
Loading

Changes in this pull request

Part of pimcore/studio-ui-bundle#102

Additional info

Introduced new concept to get settings to frontend.
Split it up in different providers instead of having it all in one big controller

@mattamon mattamon marked this pull request as draft May 16, 2024 13:34
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pimcore pimcore deleted a comment from github-actions bot May 23, 2024
@mattamon mattamon marked this pull request as ready for review May 23, 2024 10:04
@mattamon mattamon merged commit 6c74dc8 into 1.x May 23, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
@mattamon mattamon deleted the 102-settings branch May 23, 2024 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattamon