Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset Replace] Return original file name not the new one #632

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[Asset Replace] Return original file name not the new one #632

merged 1 commit into from
Dec 11, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Dec 11, 2024

Changes in this pull request

Resolves #605

@lukmzig lukmzig requested a review from mattamon December 11, 2024 10:35
@lukmzig lukmzig self-assigned this Dec 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mattamon
mattamon approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukmzig lukmzig merged commit 06358d2 into 1.x Dec 11, 2024
12 checks passed
@lukmzig lukmzig deleted the 605-wrong-behaviour-in-asset_replace-endpoint branch December 11, 2024 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@lukmzig lukmzig

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong behaviour in asset_replace endpoint
2 participants
@lukmzig @mattamon