Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Language is nullable #604

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[Task] Language is nullable #604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
479a7ec
Language is nullable
mattamon Dec 2, 2024
8b9cc53
Updating getter
mattamon Dec 2, 2024
8ea907f
Remove required
mattamon Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Version/Schema/CustomMetadataVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@
*/
#[Schema(
title: 'CustomMetadataVersion',
required: ['name', 'type', 'data'],
required: ['name', 'language', 'type', 'data'],
mattamon marked this conversation as resolved.
Show resolved Hide resolved
type: 'object'
)]
final readonly class CustomMetadataVersion
{
public function __construct(
#[Property(description: 'Name', type: 'string', example: 'custom_metadata')]
private string $name,
#[Property(description: 'Language', type: 'string', example: 'en', nullable: true)]
#[Property(description: 'Language', type: 'string', example: 'en')]
private ?string $language,
#[Property(description: 'Type', type: 'string', example: 'input')]
private string $type,
Expand All @@ -46,7 +46,7 @@ public function getName(): string
return $this->name;
}

public function getLanguage(): string
public function getLanguage(): ?string
{
return $this->language;
}
Expand Down