Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Ignore undefined data object adapters for now #583

Merged
merged 8 commits into from
Nov 28, 2024
Merged

[Improvement]: Ignore undefined data object adapters for now #583

merged 8 commits into from
Nov 28, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Nov 27, 2024

Changes in this pull request

Ignore undefined data object adapters for now as not all field types from all bundles are implemented yet

@lukmzig lukmzig requested a review from martineiber November 27, 2024 15:48
@lukmzig lukmzig self-assigned this Nov 27, 2024
@lukmzig lukmzig requested a review from mattamon November 28, 2024 06:29
mattamon
mattamon approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

martineiber
martineiber approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lukmzig
Copy link
Contributor Author

lukmzig commented Nov 28, 2024

@martineiber @mattamon
I did some additional changes. The values for setter should be rather skipped for undefined field types instead of setting them to null. We also then need a special check for the encrypted fields unfortunately as those are having "delegated" field type.

@lukmzig lukmzig merged commit 9ce4fdc into 1.x Nov 28, 2024
12 checks passed
@lukmzig lukmzig deleted the fix-missing-field-types-from-bundles branch November 28, 2024 10:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattamon mattamon Awaiting requested review from mattamon

@martineiber martineiber Awaiting requested review from martineiber

Assignees

@lukmzig lukmzig

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukmzig @martineiber @mattamon