Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColumnFilter] Trim whitespace for filterValue #567

Merged
merged 2 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/MappedParameter/Filter/SimpleColumnFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

namespace Pimcore\Bundle\StudioBackendBundle\MappedParameter\Filter;

use function is_string;

/**
* @internal
*/
Expand All @@ -34,6 +36,10 @@ public function getType(): string

public function getFilterValue(): mixed
{
if (is_string($this->filterValue)) {
return trim($this->filterValue);
}

return $this->filterValue;
}
}
40 changes: 40 additions & 0 deletions tests/Unit/MappedParameter/Filter/SimpleColumnFilterTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?php
declare(strict_types=1);

/**
* Pimcore
*
* This source file is available under two different licenses:
* - GNU General Public License version 3 (GPLv3)
* - Pimcore Commercial License (PCL)
* Full copyright and license information is available in
* LICENSE.md which is distributed with this source code.
*
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org)
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Tests\Unit\MappedParameter\Filter;

use Codeception\Test\Unit;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\Filter\SimpleColumnFilter;

/**
* @internal
*/
final class SimpleColumnFilterTest extends Unit
{
public function testTrimFilterValue(): void
{
$filter = new SimpleColumnFilter('type', ' value ');

$this->assertSame('value', $filter->getFilterValue());
}

public function testGetFilterValue(): void
{
$filter = new SimpleColumnFilter('type', ['value']);

$this->assertSame(['value'], $filter->getFilterValue());
}
}
Loading