Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] [Filter] Add filter for system.id #535

Merged
merged 6 commits into from
Nov 6, 2024
Merged

[Grid] [Filter] Add filter for system.id #535

merged 6 commits into from
Nov 6, 2024

Conversation

martineiber
Copy link
Contributor

Changes in this pull request

Resolves #529

Additional info

And change id type from system.integer to system.id

@martineiber martineiber self-assigned this Nov 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lukmzig
lukmzig approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐻

mattamon
mattamon approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇫🇷 approved

@martineiber martineiber merged commit 4faefca into 1.x Nov 6, 2024
13 checks passed
@martineiber martineiber deleted the 529-system-id-filter branch November 6, 2024 06:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattamon mattamon mattamon approved these changes

@lukmzig lukmzig lukmzig approved these changes

Assignees

@martineiber martineiber

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Grid] [Filter] Add filter for system.id
3 participants
@martineiber @lukmzig @mattamon