[Improvement] Created new schedule for update if no id is sent (#416)

* Created new schedule for update if no id is sent * Apply php-cs-fixer changes * Skip if no task found --------- Co-authored-by: mattamon <[email protected]>
pimcore · Sep 10, 2024 · dbf8196 · dbf8196
1 parent 78be334
commit dbf8196
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Schedule/Repository/ScheduleRepository.php b/src/Schedule/Repository/ScheduleRepository.php
@@ -106,7 +106,12 @@ public function updateSchedules(
 
         $currentTasks = [];
         foreach ($schedules as $schedule) {
-            $task = $this->taskResolver->getById($schedule->getId());
+
+            if ($schedule->getId()) {
+                $task = $this->taskResolver->getById($schedule->getId());
+            } else {
+                $task = $this->createSchedule($elementType, $id);
+            }
 
             if (!$task) {
                 continue;

diff --git a/src/Schedule/Schema/UpdateSchedule.php b/src/Schedule/Schema/UpdateSchedule.php
@@ -30,8 +30,8 @@
 final readonly class UpdateSchedule
 {
     public function __construct(
-        #[Property(description: 'id', type: 'integer', example: 666)]
-        private int $id,
+        #[Property(description: 'Id of schedule, if null a new one will be created', type: 'integer', example: 666)]
+        private ?int $id,
         #[Property(description: 'Date of schedule', type: 'integer', example: 1634025600)]
         private int $date,
         #[Property(description: 'Action', type: 'string', enum: ['publish', 'delete'])]
@@ -44,7 +44,7 @@ public function __construct(
 
     }
 
-    public function getId(): int
+    public function getId(): ?int
     {
         return $this->id;
     }