Adapt factory test

pimcore · Apr 12, 2024 · cd93def · cd93def
1 parent e0cb8ac
commit cd93def
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/src/Dto/DataObject.php b/src/Dto/DataObject.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 
 /**
  * Pimcore

diff --git a/tests/Unit/Service/Factory/QueryFactoryTest.php b/tests/Unit/Service/Factory/QueryFactoryTest.php
@@ -23,6 +23,7 @@
 use Pimcore\Bundle\StaticResolverBundle\Models\DataObject\ClassDefinitionResolverInterface;
 use Pimcore\Bundle\StudioApiBundle\Exception\InvalidQueryTypeException;
 use Pimcore\Bundle\StudioApiBundle\Factory\QueryFactory;
+use Pimcore\Bundle\StudioApiBundle\Factory\QueryFactoryInterface;
 use Pimcore\Bundle\StudioApiBundle\Service\GenericData\V1\AssetQuery;
 use Pimcore\Bundle\StudioApiBundle\Service\GenericData\V1\AssetQueryProviderInterface;
 use Pimcore\Bundle\StudioApiBundle\Service\GenericData\V1\DataObjectQuery;
@@ -36,7 +37,7 @@ final class QueryFactoryTest extends Unit
      */
     public function testInvalidQueryType(): void
     {
-        $queryFactory = new QueryFactory($this->mockAssetAdapterInterface());
+        $queryFactory = $this->getQueryFactory();
         $this->expectExceptionMessage('Unknown query type: invalid');
         $queryFactory->create('invalid');
     }
@@ -47,12 +48,34 @@ public function testInvalidQueryType(): void
      */
     public function testAssetQueryType(): void
     {
-        $queryFactory = new QueryFactory($this->mockAssetAdapterInterface());
+        $queryFactory = $this->getQueryFactory();
         $query = $queryFactory->create('asset');
 
         $this->assertInstanceOf(AssetQuery::class, $query);
     }
 
+
+    /**
+     * @throws InvalidQueryTypeException
+     * @throws Exception
+     */
+    public function testDataObjectQueryType(): void
+    {
+        $queryFactory = $this->getQueryFactory();
+        $query = $queryFactory->create('dataObject');
+
+        $this->assertInstanceOf(DataObjectQuery::class, $query);
+    }
+
+
+    private function getQueryFactory(): QueryFactoryInterface
+    {
+        return new QueryFactory(
+            $this->mockAssetAdapterInterface(),
+            $this->mockDataObjectAdapterInterface()
+        );
+    }
+
     /**
      * @throws Exception
      */