Skip to content

Commit

Permalink
Rename Request Namespace to MappedParameter (#85)
Browse files Browse the repository at this point in the history
* Rename request to mappedparameter and make it consistent

* Consistency check
  • Loading branch information
mattamon authored Jun 4, 2024
1 parent 0f36e6b commit 8369c21
Show file tree
Hide file tree
Showing 45 changed files with 89 additions and 88 deletions.
4 changes: 2 additions & 2 deletions src/Asset/Controller/UpdateController.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use OpenApi\Attributes\Put;
use Pimcore\Bundle\StudioBackendBundle\Asset\Attributes\Request\UpdateAssetRequestBody;
use Pimcore\Bundle\StudioBackendBundle\Asset\Attributes\Response\Content\OneOfAssetJson;
use Pimcore\Bundle\StudioBackendBundle\Asset\Request\UpdateAsset;
use Pimcore\Bundle\StudioBackendBundle\Asset\MappedParameter\UpdateAssetParameter;
use Pimcore\Bundle\StudioBackendBundle\Asset\Service\AssetServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\Controller\AbstractApiController;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\IdParameter;
Expand Down Expand Up @@ -67,7 +67,7 @@ public function __construct(
HttpResponseCodes::UNAUTHORIZED,
HttpResponseCodes::NOT_FOUND,
])]
public function updateAsset(int $id, #[MapRequestPayload] UpdateAsset $updateAsset): JsonResponse
public function updateAsset(int $id, #[MapRequestPayload] UpdateAssetParameter $updateAsset): JsonResponse
{
$this->updateService->update('asset', $id, $updateAsset->getData());
return $this->jsonResponse($this->assetService->getAsset($id));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Asset\Request;
namespace Pimcore\Bundle\StudioBackendBundle\Asset\MappedParameter;

/**
* @internal
*/
final readonly class UpdateAsset
final readonly class UpdateAssetParameter
{
public function __construct(
private array $data
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/DataObject/ClassNameFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\DataObjectQuery;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Request\DataObjectParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/ExcludeFolderFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Request\ElementParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/FilterInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
namespace Pimcore\Bundle\StudioBackendBundle\DataIndex\Filter;

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/IdSearchFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Request\ElementParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/PageFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
namespace Pimcore\Bundle\StudioBackendBundle\DataIndex\Filter;

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/PageSizeFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
namespace Pimcore\Bundle\StudioBackendBundle\DataIndex\Filter;

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/ParentIdFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Request\ElementParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Filter/PathFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Request\ElementParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/OpenSearchFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidQueryTypeException;
use Pimcore\Bundle\StudioBackendBundle\Factory\QueryFactoryInterface;
use Pimcore\Bundle\StudioBackendBundle\Filter\Service\FilterServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\Util\Constants\ElementTypes;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/OpenSearchFilterInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Pimcore\Bundle\StudioBackendBundle\DataIndex\Query\QueryInterface;
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidFilterTypeException;
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidQueryTypeException;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Request/ElementParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

namespace Pimcore\Bundle\StudioBackendBundle\DataIndex\Request;

use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParameters;

/**
* @internal
Expand Down
2 changes: 1 addition & 1 deletion src/DataIndex/Request/ElementParametersInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

namespace Pimcore\Bundle\StudioBackendBundle\DataIndex\Request;

use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParametersInterface;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParametersInterface;

/**
* @internal
Expand Down
4 changes: 2 additions & 2 deletions src/Dependency/Controller/Element/CollectionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Pimcore\Bundle\StudioBackendBundle\Controller\AbstractApiController;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Attributes\Parameters\Query\DependencyModeParameter;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Attributes\Response\Property\DependencyCollection;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Request\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\MappedParameter\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Service\DependencyServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\ElementTypeParameter;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\IdParameter;
Expand All @@ -30,7 +30,7 @@
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Response\DefaultResponses;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Response\SuccessResponse;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Config\Tags;
use Pimcore\Bundle\StudioBackendBundle\Request\ElementParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\ElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Security\Service\SecurityServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\Util\Constants\HttpResponseCodes;
use Pimcore\Bundle\StudioBackendBundle\Util\Traits\PaginatedResponseTrait;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Dependency\Request;
namespace Pimcore\Bundle\StudioBackendBundle\Dependency\MappedParameter;

use Pimcore\Bundle\StudioBackendBundle\Dependency\Service\DependencyMode;
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidDependencyMode;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParameters;
use Pimcore\Bundle\StudioBackendBundle\Util\Constants\ElementTypes;

/**
Expand All @@ -41,10 +41,11 @@ public function getMode(): DependencyMode
return $this->mode;
}

private function getDependencyMode(string $mode): DependencyMode {
private function getDependencyMode(string $mode): DependencyMode
{
$dependencyMode = DependencyMode::tryFrom($mode);

if(!$dependencyMode) {
if (!$dependencyMode) {
throw new InvalidDependencyMode('Invalid dependency mode: ' . $mode);
}

Expand Down
4 changes: 2 additions & 2 deletions src/Dependency/Service/DependencyService.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
use Pimcore\Bundle\StudioBackendBundle\Dependency\Event\DependencyEvent;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Hydrator\DependencyHydratorInterface;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Repository\DependencyRepositoryInterface;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Request\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\MappedParameter\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Response\Collection;
use Pimcore\Bundle\StudioBackendBundle\Request\ElementParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\ElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Util\Traits\ElementProviderTrait;
use Pimcore\Model\UserInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
Expand Down
4 changes: 2 additions & 2 deletions src/Dependency/Service/DependencyServiceInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

namespace Pimcore\Bundle\StudioBackendBundle\Dependency\Service;

use Pimcore\Bundle\StudioBackendBundle\Dependency\Request\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\MappedParameter\DependencyParameters;
use Pimcore\Bundle\StudioBackendBundle\Dependency\Response\Collection;
use Pimcore\Bundle\StudioBackendBundle\Request\ElementParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\ElementParameters;
use Pimcore\Model\UserInterface;

interface DependencyServiceInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Request;
namespace Pimcore\Bundle\StudioBackendBundle\MappedParameter;

use Pimcore\ValueObject\Integer\PositiveInteger;
use Symfony\Component\Validator\Constraints\NotBlank;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Request;
namespace Pimcore\Bundle\StudioBackendBundle\MappedParameter;

/**
* @internal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Request;
namespace Pimcore\Bundle\StudioBackendBundle\MappedParameter;

use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidElementTypeException;
use Pimcore\Bundle\StudioBackendBundle\Util\Constants\ElementTypes;
Expand Down
6 changes: 3 additions & 3 deletions src/Note/Controller/CollectionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidFilterException;
use Pimcore\Bundle\StudioBackendBundle\Note\Attributes\Parameters\Query\NoteSortByParameter;
use Pimcore\Bundle\StudioBackendBundle\Note\Attributes\Response\Property\NoteCollection;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteElement;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\Service\NoteServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Query\FieldFilterParameter;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Query\FilterParameter;
Expand Down Expand Up @@ -86,7 +86,7 @@ public function getNotes(
#[MapQueryString] NoteParameters $parameters = new NoteParameters()
): JsonResponse
{
$collection = $this->noteService->listNotes(new NoteElement(), $parameters);
$collection = $this->noteService->listNotes(new NoteElementParameters(), $parameters);

return $this->getPaginatedCollection(
$this->serializer,
Expand Down
6 changes: 3 additions & 3 deletions src/Note/Controller/Element/CollectionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidFilterException;
use Pimcore\Bundle\StudioBackendBundle\Note\Attributes\Parameters\Query\NoteSortByParameter;
use Pimcore\Bundle\StudioBackendBundle\Note\Attributes\Response\Property\NoteCollection;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteElement;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\Service\NoteServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\ElementTypeParameter;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\IdParameter;
Expand Down Expand Up @@ -92,7 +92,7 @@ public function getNotes(
#[MapQueryString] NoteParameters $parameters = new NoteParameters()
): JsonResponse
{
$collection = $this->noteService->listNotes(new NoteElement($elementType, $id), $parameters);
$collection = $this->noteService->listNotes(new NoteElementParameters($elementType, $id), $parameters);

return $this->getPaginatedCollection(
$this->serializer,
Expand Down
4 changes: 2 additions & 2 deletions src/Note/Controller/Element/CreateController.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementNotFoundException;
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementSavingFailedException;
use Pimcore\Bundle\StudioBackendBundle\Note\Attributes\Request\CreateNoteRequestBody;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteElement;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\Schema\CreateNote;
use Pimcore\Bundle\StudioBackendBundle\Note\Service\NoteServiceInterface;
use Pimcore\Bundle\StudioBackendBundle\OpenApi\Attributes\Parameters\Path\ElementTypeParameter;
Expand Down Expand Up @@ -73,7 +73,7 @@ public function createNote(
#[MapRequestPayload] CreateNote $createNote
): JsonResponse
{
$note = $this->noteService->createNote(new NoteElement($elementType, $id), $createNote);
$note = $this->noteService->createNote(new NoteElementParameters($elementType, $id), $createNote);
return $this->jsonResponse(['id' => $note->getId()]);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Note\Request;
namespace Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter;

/**
* @internal
*/
final readonly class NoteElement
final readonly class NoteElementParameters
{
public function __construct(
private ?string $type = null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
* @license http://www.pimcore.org/license GPLv3 and PCL
*/

namespace Pimcore\Bundle\StudioBackendBundle\Note\Request;
namespace Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter;

use JsonException;
use Pimcore\Bundle\StudioBackendBundle\Request\CollectionParameters;
use Pimcore\Bundle\StudioBackendBundle\MappedParameter\CollectionParameters;

/**
* @internal
Expand Down
8 changes: 4 additions & 4 deletions src/Note/Repository/NoteRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementNotFoundException;
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementSavingFailedException;
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidFilterException;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteElement;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\Schema\CreateNote;
use Pimcore\Bundle\StudioBackendBundle\Note\Service\FilterServiceInterface;
use Pimcore\Model\Element\Note;
Expand All @@ -43,7 +43,7 @@ public function __construct(
/**
* @throws ElementSavingFailedException
*/
public function createNote(NoteElement $noteElement, CreateNote $createNote): Note
public function createNote(NoteElementParameters $noteElement, CreateNote $createNote): Note
{
$note = new Note();
$note->setCid($noteElement->getId());
Expand Down Expand Up @@ -80,7 +80,7 @@ public function getNote(int $id): Note
/**
* @throws InvalidFilterException
*/
public function listNotes(NoteElement $noteElement, NoteParameters $parameters): NoteListing
public function listNotes(NoteElementParameters $noteElement, NoteParameters $parameters): NoteListing
{
$list = new NoteListing();

Expand Down
8 changes: 4 additions & 4 deletions src/Note/Repository/NoteRepositoryInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementNotFoundException;
use Pimcore\Bundle\StudioBackendBundle\Exception\ElementSavingFailedException;
use Pimcore\Bundle\StudioBackendBundle\Exception\InvalidFilterException;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteElement;
use Pimcore\Bundle\StudioBackendBundle\Note\Request\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteElementParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\MappedParameter\NoteParameters;
use Pimcore\Bundle\StudioBackendBundle\Note\Schema\CreateNote;
use Pimcore\Model\Element\Note;
use Pimcore\Model\Element\Note\Listing as NoteListing;
Expand All @@ -33,7 +33,7 @@ interface NoteRepositoryInterface
/**
* @throws ElementSavingFailedException
*/
public function createNote(NoteElement $noteElement, CreateNote $createNote): Note;
public function createNote(NoteElementParameters $noteElement, CreateNote $createNote): Note;

/**
* @throws ElementNotFoundException
Expand All @@ -43,7 +43,7 @@ public function getNote(int $id): ?Note;
/**
* @throws InvalidFilterException
*/
public function listNotes(NoteElement $noteElement, NoteParameters $parameters): NoteListing;
public function listNotes(NoteElementParameters $noteElement, NoteParameters $parameters): NoteListing;

/**
* @throws ElementNotFoundException
Expand Down
Loading

0 comments on commit 8369c21

Please sign in to comment.