add changes from review

pimcore · Nov 28, 2024 · 67a6fd1 · 67a6fd1
1 parent 38fb602
commit 67a6fd1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Class/Controller/QuantityValue/ConvertAllController.php b/src/Class/Controller/QuantityValue/ConvertAllController.php
@@ -55,7 +55,7 @@ public function __construct(
     }
 
     /**
-     * @throws AccessDeniedException|DatabaseException|NotFoundException|UserNotFoundException
+     * @throws DatabaseException|NotFoundException
      */
     #[Route(
         '/class/quantity-value/convert-all',
@@ -79,7 +79,7 @@ public function __construct(
         HttpResponseCodes::UNAUTHORIZED,
         HttpResponseCodes::NOT_FOUND,
     ])]
-    public function get(#[MapRequestPayload] ConvertAllParameters $parameters): JsonResponse
+    public function covertAll(#[MapRequestPayload] ConvertAllParameters $parameters): JsonResponse
     {
         return $this->jsonResponse($this->quantityValueService->convertAllUnits($parameters));
     }

diff --git a/src/Class/Controller/QuantityValue/ConvertController.php b/src/Class/Controller/QuantityValue/ConvertController.php
@@ -76,7 +76,7 @@ public function __construct(
         HttpResponseCodes::UNAUTHORIZED,
         HttpResponseCodes::NOT_FOUND,
     ])]
-    public function get(#[MapRequestPayload] ConvertParameters $parameters): JsonResponse
+    public function convert(#[MapRequestPayload] ConvertParameters $parameters): JsonResponse
     {
         return $this->jsonResponse(['data' => $this->quantityValueService->convertUnit($parameters)]);
     }

diff --git a/src/Class/Repository/QuantityValueRepository.php b/src/Class/Repository/QuantityValueRepository.php
@@ -22,7 +22,7 @@
 /**
  * @internal
  */
-class QuantityValueRepository implements QuantityValueRepositoryInterface
+final readonly class QuantityValueRepository implements QuantityValueRepositoryInterface
 {
     /**
      * @return Unit[]