add some missing internal error responses

pimcore · Dec 10, 2024 · 6153c3a · 6153c3a
1 parent c0d67a9
commit 6153c3a
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/src/Asset/Controller/GetController.php b/src/Asset/Controller/GetController.php
@@ -64,8 +64,9 @@ public function __construct(
         content: new OneOfAssetJson()
     )]
     #[DefaultResponses([
-        HttpResponseCodes::UNAUTHORIZED,
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::NOT_FOUND,
+        HttpResponseCodes::UNAUTHORIZED,
     ])]
     public function getAssetById(int $id): JsonResponse
     {

diff --git a/src/Asset/Controller/Grid/Configuration/GetAvailableColumnsController.php b/src/Asset/Controller/Grid/Configuration/GetAvailableColumnsController.php
@@ -75,8 +75,9 @@ public function __construct(
         )
     )]
     #[DefaultResponses([
-        HttpResponseCodes::UNAUTHORIZED,
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::NOT_FOUND,
+        HttpResponseCodes::UNAUTHORIZED,
     ])]
     public function getAvailableAssetGridColumns(): JsonResponse
     {

diff --git a/src/Asset/Controller/Grid/Configuration/GetConfigurationController.php b/src/Asset/Controller/Grid/Configuration/GetConfigurationController.php
@@ -72,8 +72,9 @@ public function __construct(
         content: new JsonContent(ref: DetailedConfiguration::class)
     )]
     #[DefaultResponses([
-        HttpResponseCodes::UNAUTHORIZED,
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::NOT_FOUND,
+        HttpResponseCodes::UNAUTHORIZED,
     ])]
     public function getAssetGridConfiguration(
         int $folderId,

diff --git a/src/Asset/Controller/Grid/Configuration/ListSavedConfigurationsController.php b/src/Asset/Controller/Grid/Configuration/ListSavedConfigurationsController.php
@@ -72,6 +72,7 @@ public function __construct(
         content: new CollectionJson(new GenericCollection(Configuration::class))
     )]
     #[DefaultResponses([
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::UNAUTHORIZED,
         HttpResponseCodes::NOT_FOUND,
     ])]

diff --git a/src/Asset/Controller/Image/ThumbnailDownloadController.php b/src/Asset/Controller/Image/ThumbnailDownloadController.php
@@ -82,8 +82,9 @@ public function __construct(
         headers: [new ContentDisposition()]
     )]
     #[DefaultResponses([
-        HttpResponseCodes::UNAUTHORIZED,
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::NOT_FOUND,
+        HttpResponseCodes::UNAUTHORIZED,
     ])]
     public function downloadImageByThumbnail(int $id, string $thumbnailName): BinaryFileResponse
     {

diff --git a/src/Asset/Controller/TreeController.php b/src/Asset/Controller/TreeController.php
@@ -88,8 +88,9 @@ public function __construct(
         content: new CollectionJson(new AnyOfAsset())
     )]
     #[DefaultResponses([
-        HttpResponseCodes::UNAUTHORIZED,
+        HttpResponseCodes::BAD_REQUEST,
         HttpResponseCodes::NOT_FOUND,
+        HttpResponseCodes::UNAUTHORIZED,
     ])]
     public function getAssetTree(#[MapQueryString] ElementParameters $parameters): JsonResponse
     {