Skip to content
Static Analysis

Improve request and response schemas #174

Sign in to view logs

Improve request and response schemas

Improve request and response schemas #174

Triggered via pull request April 18, 2024 07:33
@mattamonmattamon
opened #30
improve-response-schema
Status Failure
Total duration 1m 47s
Billable time 3m
Artifacts 1

static-analysis.yaml

on: pull_request
Matrix: Static Analysis with PHPStan
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
Static Analysis with PHPStan (8.2, highest, false): src/Service/AssetSearchService.php#L44
Method Pimcore\Bundle\StudioApiBundle\Service\AssetSearchService::getAssetById() should return Pimcore\Bundle\StudioApiBundle\Response\Asset|null but returns Pimcore\Bundle\StudioApiBundle\Dto\Asset|null.
Static Analysis with PHPStan (8.2, highest, false): src/Service/GenericData/AssetSearchAdapterInterface.php#L27
Method Pimcore\Bundle\StudioApiBundle\Service\GenericData\AssetSearchAdapterInterface::getAssetById() has invalid return type Pimcore\Bundle\StudioApiBundle\Dto\Asset.
Static Analysis with PHPStan (8.2, highest, false): src/Service/GenericData/V1/AssetSearchAdapter.php#L56
Method Pimcore\Bundle\StudioApiBundle\Service\GenericData\V1\AssetSearchAdapter::getAssetById() has invalid return type Pimcore\Bundle\StudioApiBundle\Dto\Asset.
Static Analysis with PHPStan (8.2, highest, false): src/Service/GenericData/V1/AssetSearchAdapter.php#L63
Method Pimcore\Bundle\StudioApiBundle\Service\GenericData\V1\AssetSearchAdapter::getAssetById() should return Pimcore\Bundle\StudioApiBundle\Dto\Asset|null but returns Pimcore\Bundle\StudioApiBundle\Response\Asset.
Static Analysis with PHPStan (8.2, highest, false)
Process completed with exit code 1.
Static Analysis with PHPStan (8.2, highest, 11.x-dev as 11.99.9, true)
The job was canceled because "_8_2_highest_false" failed.
Static Analysis with PHPStan (8.2, highest, false)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Static Analysis with PHPStan (8.2, highest, false)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
phpstan-baseline.neon Expired
1.29 KB