Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Targeting] Error on Syfmony Profiler with pimcore targeting enabled #57 #58

Merged
merged 5 commits into from
Oct 31, 2023
Merged

[Targeting] Error on Syfmony Profiler with pimcore targeting enabled #57 #58

merged 5 commits into from
Oct 31, 2023

Conversation

ogmdev
Copy link
Contributor

@ogmdev ogmdev commented Oct 16, 2023

Should fix #57

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ogmdev
Copy link
Contributor Author

ogmdev commented Oct 16, 2023

I have read the CLA Document and I hereby sign the CLA

@aryaantony92 aryaantony92 self-assigned this Oct 25, 2023
@aryaantony92 aryaantony92 added this to the 1.0.3 milestone Oct 25, 2023
@aryaantony92
Copy link
Contributor

aryaantony92 commented Oct 25, 2023 •
edited
Loading

@ogmdev Could you please rebase the base branch to 1.0 as this is a bug fix ?

@aryaantony92 aryaantony92 changed the base branch from 1.x to 1.0 October 25, 2023 13:28
@aryaantony92 aryaantony92 changed the base branch from 1.0 to 1.x October 25, 2023 13:29
@aryaantony92
Copy link
Contributor

Permanent fix would be moving the file from the Core bundle to here #60

@aryaantony92 aryaantony92 mentioned this pull request Oct 25, 2023
Closed
@dvesh3 dvesh3 assigned dvesh3 and unassigned aryaantony92 Oct 31, 2023
@dvesh3 dvesh3 changed the base branch from 1.x to 1.0 October 31, 2023 14:01
@dvesh3 dvesh3 merged commit fd608b7 into pimcore:1.0 Oct 31, 2023
7 checks passed
@dvesh3
Copy link
Contributor

dvesh3 commented Oct 31, 2023

@ogmdev thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NiklasBr NiklasBr NiklasBr left review comments

@aryaantony92 aryaantony92 aryaantony92 approved these changes

Assignees

@dvesh3 dvesh3

Labels
Bug
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

[Targeting] Error on Syfmony Profiler with pimcore targeting enabled
4 participants
@ogmdev @aryaantony92 @dvesh3 @NiklasBr