Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added compatibility for pimcore 11 #10

Merged
merged 3 commits into from
Jul 31, 2024
Merged

fix: added compatibility for pimcore 11 #10

merged 3 commits into from
Jul 31, 2024

Conversation

zoidbergx
Copy link
Contributor

added minimum compatiblity and small adaptions for this bundle to have it runnable within Pimcore 11:

  • added "vendor" folder to gitignore
  • added ecommerce framework bundle as the Installer Class of this Bundle has a direct dependency to it
  • added types for $bricksPath and bricksToInstall to be compatible with the base class

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 29, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
12 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@markus-moser markus-moser self-assigned this Jul 31, 2024
@markus-moser markus-moser added this to the v2.0.0 milestone Jul 31, 2024
@markus-moser markus-moser merged commit b09ca88 into pimcore:2.x Jul 31, 2024
4 checks passed
@markus-moser
Copy link
Contributor

Great, thanks a lot 👍

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@markus-moser markus-moser

Labels
Pimcore:ToDo Task
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zoidbergx @markus-moser @wisconaut