Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from #875 #910

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Fix regression from #875 #910

merged 3 commits into from
Nov 7, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Nov 6, 2024

Followup to #875 and #890

$brickDescriptor is an array. I get following errors:

Uncaught TypeError: Pimcore\Bundle\DataHubBundle\GraphQL\Service::getValueFromObjectBrick(): Argument #4 ($brickDescriptor) must be of type ?string, array given

@blankse
Copy link
Contributor Author

blankse commented Nov 6, 2024

Please fix this also with a 1.7.5 release. The 1.7.3 and 1.7.4 releases are buggy and 1.8.x can't be installed in Pimcore 10.

Copy link

sonarqubecloud bot commented Nov 6, 2024

@mcop1
Copy link
Contributor

mcop1 commented Nov 7, 2024

@blankse Thanks again, I will do a 1.7.5 bugfix release, merge it to 1.8 afterwards and do a bugfix release there too.

@mcop1 mcop1 merged commit f627051 into pimcore:1.7 Nov 7, 2024
8 checks passed
@blankse blankse deleted the patch-1 branch November 7, 2024 12:54
@mcop1 mcop1 added this to the 1.7.5 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants