Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant for 'datahub_context' instead hardcoded value #880

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Use constant for 'datahub_context' instead hardcoded value #880

merged 4 commits into from
Sep 27, 2024

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Sep 16, 2024

Code improvements and using constant instead hardcoded key.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 self-assigned this Sep 27, 2024
@mcop1 mcop1 changed the base branch from 1.7 to 1.8 September 27, 2024 07:02
@mcop1 mcop1 added this to the 1.8.2 milestone Sep 27, 2024
@mcop1
Copy link
Contributor

mcop1 commented Sep 27, 2024

Looks good to me, thank you 👍

@mcop1 mcop1 merged commit 90cca98 into pimcore:1.8 Sep 27, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vmalyk @mcop1 @wisconaut