-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Replace Request::get with explicit input sources #874
Conversation
Quality Gate passedIssues Measures |
@kingjia90 What does it need to be finished? Could we already merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to update
data-hub/doc/10_GraphQL/10_Events.md
Line 260 in 836c690
$uri = $event->getRequest()->getMethod(); |
data-hub/doc/10_GraphQL/10_Events.md
Line 273 in 836c690
$uri = $event->getRequest()->getMethod(); |
no needed because it's not marked as internal |
Ok, then it looks good to me, thanks :) |
Resolves #679
Related pimcore/pimcore#14138