Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 Support #840

Merged
merged 5 commits into from
Jun 12, 2024
Merged

PHP 8.3 Support #840

merged 5 commits into from
Jun 12, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Feb 29, 2024 •
edited
Loading

@blankse blankse mentioned this pull request Mar 22, 2024
Merged
This was referenced May 22, 2024
Closed
Merged
@fashxp fashxp added this to the 1.8.0 milestone Jun 11, 2024
@blankse blankse mentioned this pull request Jun 11, 2024
Merged
@fashxp fashxp changed the base branch from 1.x to 1.7 June 11, 2024 14:20
@fashxp fashxp modified the milestones: 1.8.0, 1.7.2 Jun 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fashxp fashxp self-assigned this Jun 12, 2024
Corepex
Corepex approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fashxp
Copy link
Member

fashxp commented Jun 12, 2024

thank you very much.
merging that int the bugfix branch since next minor is just half the way finished and we don't want to wait for it.

@fashxp fashxp merged commit 34e8dff into pimcore:1.7 Jun 12, 2024
7 checks passed
@blankse blankse deleted the php_8_3 branch June 12, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corepex Corepex Corepex approved these changes

Assignees

@fashxp fashxp

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@blankse @fashxp @Corepex @wisconaut