Fixed error message for import (#898)

pimcore · Oct 21, 2024 · 9f4a052 · 9f4a052
1 parent b71636a
commit 9f4a052
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/src/Controller/ConfigController.php b/src/Controller/ConfigController.php
@@ -576,19 +576,23 @@ public function exportConfiguration(Request $request, ExportService $exportServi
      */
     public function importConfiguration(Request $request, ImportService $importService): JsonResponse
     {
-        $this->checkPermission(self::CONFIG_NAME);
-        $json = file_get_contents($_FILES['Filedata']['tmp_name']);
-        $configuration = $importService->importConfigurationJson($json);
-
-        $response = $this->jsonResponse([
-            'success' => true,
-            'type' => $configuration->getType(),
-            'name' => $configuration->getName(),
-        ]);
-        // set content-type to text/html, otherwise (when application/json is sent) chrome will complain in
-        // Ext.form.Action.Submit and mark the submission as failed
-        $response->headers->set('Content-Type', 'text/html');
+        try {
+            $this->checkPermission(self::CONFIG_NAME);
+            $json = file_get_contents($_FILES['Filedata']['tmp_name']);
+            $configuration = $importService->importConfigurationJson($json);
 
-        return $response;
+            $response = $this->jsonResponse([
+                'success' => true,
+                'type' => $configuration->getType(),
+                'name' => $configuration->getName(),
+            ]);
+            // set content-type to text/html, otherwise (when application/json is sent) chrome will complain in
+            // Ext.form.Action.Submit and mark the submission as failed
+            $response->headers->set('Content-Type', 'text/html');
+
+            return $response;
+        } catch (\Exception $e) {
+            return $this->jsonResponse(['success' => false, 'message' => $e->getMessage()]);
+        }
     }
 }
diff --git a/src/Resources/public/js/config.js b/src/Resources/public/js/config.js
@@ -124,8 +124,10 @@ pimcore.plugin.datahub.config = Class.create({
                             this.refreshTree();
 
                         }.bind(this),
-                        function () {
-                            Ext.MessageBox.alert(t("error"), t("error"));
+                        function (response) {
+                            response = response.response;
+                            const data = Ext.decode(response.responseText);
+                            Ext.MessageBox.alert(t("error"), data.message);
                         }
                     );
                 }.bind(this)