[Bug][Data loss]: if passing an invalid asset.id, fullpath to object …

…mutation GraphQL query, the assets are silently discarded (#825) * Fix: throw error message * Fix: throw error message * Apply suggestion by covering all the relational types and improve exception message * Update ManyToOneRelation.php * Apply php-cs-fixer changes --------- Co-authored-by: jiajia <[email protected]> Co-authored-by: kingjia90 <[email protected]>
pimcore · Feb 21, 2024 · 2d8d815 · 2d8d815
1 parent 0263330
commit 2d8d815
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 0 deletions.
diff --git a/src/GraphQL/DataObjectInputProcessor/AdvancedManyToManyObjectRelation.php b/src/GraphQL/DataObjectInputProcessor/AdvancedManyToManyObjectRelation.php
@@ -21,6 +21,7 @@
 use Pimcore\Model\DataObject\Concrete;
 use Pimcore\Model\DataObject\Data\ObjectMetadata;
 use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData;
+use Pimcore\Model\Exception\NotFoundException;
 
 class AdvancedManyToManyObjectRelation extends Base
 {
@@ -58,6 +59,13 @@ public function process($object, $newValue, $args, $context, ResolveInfo $info)
                             $item->setData($data);
                         }
                         $result[] = $item;
+                    } else {
+                        throw new NotFoundException(
+                            sprintf('Element with id %s or fullpath %s not found',
+                                $newValueItemValue['id'],
+                                $newValueItemValue['fullpath']
+                            )
+                        );
                     }
                 }
             }

diff --git a/src/GraphQL/DataObjectInputProcessor/AdvancedManyToManyRelation.php b/src/GraphQL/DataObjectInputProcessor/AdvancedManyToManyRelation.php
@@ -21,6 +21,7 @@
 use Pimcore\Model\DataObject\Concrete;
 use Pimcore\Model\DataObject\Data\ElementMetadata;
 use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData;
+use Pimcore\Model\Exception\NotFoundException;
 
 class AdvancedManyToManyRelation extends Base
 {
@@ -57,6 +58,13 @@ public function process($object, $newValue, $args, $context, ResolveInfo $info)
                             $item->setData($data);
                         }
                         $result[] = $item;
+                    } else {
+                        throw new NotFoundException(
+                            sprintf('Element with id %s or fullpath %s not found',
+                                $newValueItemValue['id'],
+                                $newValueItemValue['fullpath']
+                            )
+                        );
                     }
                 }
             }

diff --git a/src/GraphQL/DataObjectInputProcessor/ManyToManyObjectRelation.php b/src/GraphQL/DataObjectInputProcessor/ManyToManyObjectRelation.php
@@ -21,6 +21,7 @@
 use Pimcore\Bundle\DataHubBundle\GraphQL\Traits\ElementIdentificationTrait;
 use Pimcore\Model\DataObject\Concrete;
 use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData;
+use Pimcore\Model\Exception\NotFoundException;
 
 class ManyToManyObjectRelation extends Base
 {
@@ -50,6 +51,13 @@ public function process($object, $newValue, $args, $context, ResolveInfo $info)
 
                     if ($element) {
                         $result[] = $element;
+                    } else {
+                        throw new NotFoundException(
+                            sprintf('Element with id %s or fullpath %s not found',
+                                $newValueItemValue['id'],
+                                $newValueItemValue['fullpath']
+                            )
+                        );
                     }
                 }
             }

diff --git a/src/GraphQL/DataObjectInputProcessor/ManyToManyRelation.php b/src/GraphQL/DataObjectInputProcessor/ManyToManyRelation.php
@@ -20,6 +20,7 @@
 use Pimcore\Bundle\DataHubBundle\GraphQL\Traits\ElementIdentificationTrait;
 use Pimcore\Model\DataObject\Concrete;
 use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData;
+use Pimcore\Model\Exception\NotFoundException;
 
 class ManyToManyRelation extends Base
 {
@@ -45,6 +46,13 @@ public function process($object, $newValue, $args, $context, ResolveInfo $info)
 
                     if ($element) {
                         $result[] = $element;
+                    } else {
+                        throw new NotFoundException(
+                            sprintf('Element with id %s or fullpath %s not found',
+                                $newValueItemValue['id'],
+                                $newValueItemValue['fullpath']
+                            )
+                        );
                     }
                 }
             }

diff --git a/src/GraphQL/DataObjectInputProcessor/ManyToOneRelation.php b/src/GraphQL/DataObjectInputProcessor/ManyToOneRelation.php
@@ -20,6 +20,7 @@
 use Pimcore\Bundle\DataHubBundle\GraphQL\Traits\ElementIdentificationTrait;
 use Pimcore\Model\DataObject\Concrete;
 use Pimcore\Model\DataObject\Fieldcollection\Data\AbstractData;
+use Pimcore\Model\Exception\NotFoundException;
 
 class ManyToOneRelation extends Base
 {
@@ -40,8 +41,18 @@ public function process($object, $newValue, $args, $context, ResolveInfo $info):
         $me = $this;
         Service::setValue($object, $attribute, function ($container, $setter) use ($newValue) {
             $element = null;
+
             if (is_array($newValue)) {
                 $element = $this->getElementByTypeAndIdOrPath($newValue);
+
+                if (!$element) {
+                    throw new NotFoundException(
+                        sprintf('Element with id %s or fullpath %s not found',
+                            $newValue['id'],
+                            $newValue['fullpath']
+                        )
+                    );
+                }
             }
 
             return $container->$setter($element);