Add support for cursor direction #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for directional cursors.
It was thrown together pretty quickly, so feedback/checking for bugs is appreciated. It should be backwards compatible for the most part - the
Cursorinterface has been updated to take two new functions:ParseDirectionAndCursor&SerialiseDirectionAndCursor. Under the hood these just append a marker for the direction -EncodeandDecodestill exist and do most of the heavy lifting.I have opted not to remove the original
SetBeforeCursor/SetAfterCursorlogic, as I'm not sure if there was a reason behind that initial decision that means it's still a vaild usecase. If not then this PR can be simplified, contributions welcome.There is scope for end users to mess things up if they inadvertently mix non-directional cursors with directional cursors, though I've updated the docs, and it should be relatively self-explanatory how it works, so I'm not sure how much of an issue that really is.
Thoughts and feedback welcome, @pilagod & @Virviil pinging as you've both raised/discussed related issues in #66 & #67 respectively.