Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NETRC to download files #178

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jlegaul7
Copy link

@jlegaul7 jlegaul7 commented Aug 15, 2024

As it stands, kvmd does not use netrc to download files, this mr adds the missing flag to let aiohttp use netrc for authentication.


Reference:
https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession

trust_env (bool) – Trust environment settings for proxy configuration if the parameter is True (False by default).
  Get proxy credentials from ~/.netrc file if present.
  Get HTTP Basic Auth credentials from ~/.netrc file if present.
  If `NETRC` environment variable is set, read from file specified there rather than from ~/.netrc.

As it stands, kvmd does not use netrc to download files which makes downloading files off of site requiring authentication infeasible.

this commit adds the missing flag to let aiohttp use netrc for authetication
@jlegaul7 jlegaul7 marked this pull request as draft August 15, 2024 18:00
@jlegaul7 jlegaul7 marked this pull request as ready for review August 15, 2024 20:58
@mdevaev
Copy link
Member

mdevaev commented Aug 17, 2024

Maybe settings in override.yaml will be a better solution?

@jlegaul7 jlegaul7 marked this pull request as draft August 17, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants