Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special chars escaped by the markdown renderer, close #159 #191

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Fix special chars escaped by the markdown renderer, close #159 #191

merged 3 commits into from
Mar 21, 2023

Conversation

neroist
Copy link
Contributor

@neroist neroist commented Mar 21, 2023 •
edited
Loading

Implements the fix described here. Also adds tests for markdown rendering.

HugoGranstrom
HugoGranstrom approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@HugoGranstrom HugoGranstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks again for your contribution 🚀

@pietroppeter
Copy link
Owner

vey nice, we will need to make a release with all those improvements!

@pietroppeter pietroppeter merged commit 843677a into pietroppeter:main Mar 21, 2023
@HugoGranstrom
Copy link
Collaborator

vey nice, we will need to make a release with all those improvements!

Absolutely! Go ahead :D

@pietroppeter
Copy link
Owner

Are you planning to tackle something else in the short term @neroist ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoGranstrom HugoGranstrom HugoGranstrom approved these changes

@pietroppeter pietroppeter pietroppeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neroist @pietroppeter @HugoGranstrom