Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll wheel support for setting gain #63

Merged
merged 1 commit into from
May 21, 2024
Merged

Add scroll wheel support for setting gain #63

merged 1 commit into from
May 21, 2024

Conversation

neilenns
Copy link
Contributor

Fixes #60

  • Adds an onWheel event handler to the gain label and slider, capping the gain between 0 and 100 in 1 step
  • Refactors the code to set the gain out to its own method
  • Use that refactored method in both the onWheel and onSlider event handlers
  • Updates the slider to use value instead of defaultValue so it updates automatically when the gain value changes

In action:

mousewheel

@pierr3 pierr3 merged commit 2ee389b into pierr3:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll Wheel Support on Gain Setting
2 participants
@neilenns @pierr3