Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previous window position when toggling between mini and maxi mode #103

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Jun 5, 2024

Fixes #102

  • Save the window position of mini mode window
  • Use the bounds instead of size when toggling between mini and maxi mode
  • Split the width breakpoint for resized mini mode and the default mini mode width into two numbers. This maintains the current small size for people have never used mini mode before but allows people to make the mini mode window wider to match vATIS if they want.

This works great in all my testing as long as both mini and maxi are on the same monitor. If you put mini on one monitor and maxi on the other monitor, and the monitors have different pixel densities, then the resizing and positioning doesn't work quite right. I can spend time in another PR trying to make that better, but it seemed edge case enough to not worry about adding complexity to fix it to this PR.

Here's the behaviour with this fix:

after

@pierr3 pierr3 merged commit e729089 into pierr3:main Jun 5, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling between mini and maxi mode should use previous window position
2 participants