Add some explanation for self declared meta headers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhrozenByte
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Thank you for your contribution! 👍 Good idea, I think we should definitely add some explanation.
Please follow the overall maximum line length of 120 chars, see Social: social below for how to deal with longer lines. Instead of "i.e." please use "e.g." to properly call it an example. In general, the explanation should probably stick a little closer to that of Pico's onMetaHeaders event (it doesn't have to be the same, just more similar, because from the current explanation personally I wouldn't really understand it), see DummyPlugin::onMetaHeaders().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like discussed and promised in picocms/Pico#684